Add tuple and unit struct support for pyclass macro #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
pyclass
branch
2 times, most recently
from
a284b88 to
b95bccf
Compare
davidhewitt
reviewed
Mar 18, 2021
| } | ||
| _ => unreachable!(), | ||
| } else { | ||
| bail_spanned!(field.span() => "get/set are not supported on tuple struct field"); |
There was a problem hiding this comment.
I'm curious what the reason for disallowing get/set is? I was thinking that it should be possible, but a name would be required.
e.g. this seems a plausible combination to me:
#[pyclass]
struct PyFoo(
#[pyo3(get, set, name = "inner", from_py_with = "pytimestamp_to_int")] i32,
);I'm happy for us to create an issue to leave this for a follow-up PR.
There was a problem hiding this comment.
It was disallowed just to avoid proc-maco panic when user try to use get/set on it. We can certainly add support for it, I think we can do the follow-up after #1507 merged.
There was a problem hiding this comment.
Hi @davidhewitt and @messense This's nice! And as a local wrapper of external structure, I think we still can't get them work with nested getter and setter, which is get_all and set_all?
Comment on lines
+28
to
+29
| // By default, don't allow creating instances from python. | ||
| assert!(typeobj.call((), None).is_err()); |
Co-authored-by: Yuji Kanagawa <yuji.kngw.80s.revive@gmail.com>
|
Thanks! |
kngwyu
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287 (comment)